FIX: Allow switching to/from masonry mode with loading slider #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a check for `displayMasonry` in the topic-list component `didInsertElement` hook is problematic because, under the loading slider, the topic-list component may be re-used across different routes. Instead, we can set up the resizeObserver unconditionally. It's cheap to set up, and it only has an effect on topic lists which actually have masonry mode enabled.
CvX
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a check for
displayMasonryin the topic-list componentdidInsertElementhook is problematic because, under the loading slider, the topic-list component may be re-used across different routes. Instead, we can set up the resizeObserver unconditionally. It's cheap to set up, and it only has an effect on topic lists which actually have masonry mode enabled.