FEATURE: Apply category filters when filtered by tag #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also takes the opportunity to convert the service to native class syntax, and lean on the new 'discovery' service for finding the active category/tag in a safe way.
tgxworld
reviewed
Nov 16, 2023
| @@ -1,2 +1,2 @@ | |||
| < 3.2.0.beta4-dev: b3c727286bdad3661d6cb2b83e369588e91b458f | |||
There was a problem hiding this comment.
I ran into compatibility problems when using an unreleased version previously because 3.2.0.beta4-dev can represent a wide range of Discourse core commits. Does the feature being introduced here rely on a Discourse core change that has yet to be released? If so, we might need to be more careful here.
There was a problem hiding this comment.
The discovery service was included in the 3.2.0.beta3 release, so we should be safe 👌
tgxworld
approved these changes
Nov 16, 2023
|
Thanks @tgxworld 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also takes the opportunity to convert the service to native class syntax, lean on the new 'discovery' service for finding the active category/tag in a safe way, and clean up some old hacks.