Feat: Simulate unbuffed hero panel attributes #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed preview build to Cloudflare!
|
marcustyphoon
force-pushed
the
display-no-buffs-2
branch
from
6d111a3
to
db68b76
Compare
marcustyphoon
force-pushed
the
display-no-buffs-2
branch
from
09970e8
to
7e329e9
Compare
marcustyphoon
force-pushed
the
display-no-buffs-2
branch
from
7e329e9
to
6f379f6
Compare
marcustyphoon
force-pushed
the
display-no-buffs-2
branch
from
6f379f6
to
37d2c31
Compare
marcustyphoon
force-pushed
the
display-no-buffs-2
branch
from
37d2c31
to
74a19ff
Compare
marcustyphoon
force-pushed
the
display-no-buffs-2
branch
from
74a19ff
to
afd382b
Compare
marcustyphoon
force-pushed
the
display-no-buffs-2
branch
from
ca404df
to
7b91acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a long-requested toggle to simulate character attributes when out of combat, so users can compare the ingame hero panel to the optimizer's. This is not, and cannot, be perfect (at least without more user input UI). Is a soulbeast player equipping an axe? A torch or dagger? Both? Neither? There's no way to know or assume in a way that would be consistent for every build.
On a best-effort basis, this assumes that an elementalist is in fire attunement (not air) and a power guardian or warrior isn't on their greatsword set; these are kind of arbitrary and the UI warning shouldn't commit to us keeping those kinds of things true as it's quite hard.
I don't know how to integrate this into the UI; not a big fan of what's committed here at all. Maybe an implementation within the
<Character>component? That would allow the main site to have this toggle, which obviously a ton of people want. Help wanted there.(Simulation changes and data fields for this feature were merged in #726 and are live.)
Notes:
[draft previews]