feat: Update to typescript@5 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously stuck on typescript 4.7.4 due to dependencies on
typescript-isandttypescriptin theapi-typecheckscript used to verify that the API types are correct in gw2-ui. This migrates to their recommended replacements and to the latest typescript version.Note that patching typescript at all may be kind of pointless;
typiaships ageneratefunction that could be used instead of rollup, and the whole script could be in typescript and run withtsx. This is used in the gear optimizer: https://github.com/discretize/discretize-gear-optimizer/blob/main/src/assets/typevalidation/index.ts / https://github.com/discretize/discretize-gear-optimizer/blob/0c95df443043c8d3366771ee5ddc365f475ac039/package.json#L37