Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for composer #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

drexarj
Copy link

@drexarj drexarj commented Nov 7, 2013

Composer is a dependency manager for PHP that is highly used among developers and their libraries. http://getcomposer.org/

This commit adds support for composer packaging for this library.

Please take notice that after accepting this pull request Disqus have to officially add the library in Packagist.
https://packagist.org/packages/submit

Signed-off-by: Alex Rico [email protected]

Signed-off-by: Alex Rico <[email protected]>
@slashrsm
Copy link

+1 to see composer support in the library. Not having this support causes a lot of confusion as there are forks existing only to provide composer support and packages on packagist.org. Would be great if official library could provide that.

Not sure why Travis failed, but this simple addition of composer.json file should not have any affect to code itself.

Came to this issue finding a solution for Drupal 8 module that we're working on. Drupal 8 uses composer a lot. It will be the standard way of providing 3rd party libraries where needed. I'd really rather include official library than any of "provide composer support" forks.

@@ -0,0 +1,13 @@
{
"name": "drexarj/disqus-php",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will definitely need to be changed.

@mattrobenolt
Copy link
Collaborator

@slashrsm Since this PR is almost a year old, would you just like to submit a new one? Not sure if OP will see and update. :)

@slashrsm
Copy link

slashrsm commented Aug 5, 2014

Done: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants