-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acceptance of query types in required arguments #6
base: master
Are you sure you want to change the base?
Conversation
Going to discuss this over internally, as right now query types are sort of a hack. The current interface.json implementation is actually able to be auto generated, and we'll need to add support for query types proper so that they can be included in that to do a release. |
Yeah, I had to hack it to do this as well. My hack is a little less involved. |
I think that last commit should probably of been patched against a fresh fork ... let me know if you need it done. |
So now you can use:
$data = array('forum' => 'forum_name', 'thread:ident' => 'ident');
json configuration feels a little clunky, but does its job.
"details": {
"required": [
"thread"
],
"query_type": {
"requires": "forum",
"insteadof": "thread",
"with_either": ["thread:ident", "thread:link" ]
},
"method": "GET",
"formats": [
"json",
"jsonp"
]
},
I have only updated the configuration for the threads commands (not sure if anything else is missing).