Chart enhancements + stub of `places` and `districtingProblems` #167

mariogiampieri · 2024-11-11T05:10:16Z

Description

Chart behavior based on MapDocument properties, including a target number of districts (manually set for now) and a total population. This chart behavior includes:
- an ideal population per zone indicated as a vertical labelled line
- the chart x-max set based on ideal pop * 2 or dataMax, whichever is larger (i.e. if someone is going overboard the chart will follow
- separately, setting the # of colors in the palette to equal the target # of districts.

Re: places and problems, to circle back on:

Create draft DistrictrPlace and DistrictrProblem models, following v1 places / problems and syntax that a user selects to start a session. This was in service of getting the proper target # districts for each map. I suspect that we'll want to discuss and revise how these objects fit in with our data model. For now at least, they provide a target for each test map, based on districtr v1 statewide places and problems
Per the above, utility scripts (still WIP) to load data from districtr v1 into these new tables. Again, we should discuss where these things should live long term (holding for a later branch)

Reviewers

Primary:
Secondary:

Checklist

Added/Updated related documentation (if applicable).
Added/Updated related unit tests (if applicable).

Screenshots (if applicable):

…r-v1 into summary-stats

if used it's then explicit

not fully reactive yet

mariogiampieri · 2024-11-16T15:51:52Z

Ok, the chart is working as intended now, with a pin put in the places and problems. The num_districts can be manually set for now for the chart to behave properly.

nofurtherinformation

I added a couple small comments but FE stuff looks good to me for user testing. I didn't look too deeply into the backend work here for now

nofurtherinformation · 2024-11-18T15:38:34Z

app/src/app/components/sidebar/charts/HorizontalBarChart.tsx

+    }
+  }, [summaryStats, numDistricts]);
+
+  const calculateChartObject = () => {


PP: calculateChartObject and the useEffect on 72 would be more readable with useMemo instead

nofurtherinformation · 2024-11-18T15:41:29Z

app/src/app/components/sidebar/charts/HorizontalBarChart.tsx

+  useEffect(() => {
+    if (summaryStats && numDistricts) {
+      const totalPop = summaryStats.totpop ? getEntryTotal(summaryStats.totpop.data) : 0;
+      setIdealPopulation(totalPop / numDistricts);


PP: This could make more sense as mapStore.summaryStats.idealPopulation -- are there other places we'd want to have this number available?

Could be queries.ts:72

nice! good call

… feat/chart-enhancements

raphaellaude

Only one blocking comment to delete unused UDF. Let's handle the two_or_more_races_pop issue in a separate PR to get this in.

raphaellaude · 2024-11-19T04:19:48Z

app/src/app/components/sidebar/charts/HorizontalBarChart.tsx

@@ -44,30 +88,49 @@ export const HorizontalBar = () => {
  return (
    <Flex gap="3" direction="column">
      <Heading as="h3" size="3">
-        Population by Zone
+        Population by District


PP: looks like Moon has been using sentence case which I think is better style -> Population by district

raphaellaude · 2024-11-19T04:22:06Z

app/src/app/utils/api/apiHandlers.ts


 export const P1ZoneSummaryStatsKeys = [
  'other_pop',
  'asian_pop',
  'amin_pop',
  'nhpi_pop',
  'black_pop',
-  'white_pop'
-] as const
+  'white_pop',


I: Will want to add two_or_more_races_pop here

Will handle in separate PR

raphaellaude · 2024-11-19T04:22:19Z

app/src/app/utils/api/apiHandlers.ts

@@ -192,7 +192,7 @@ export const CleanedP1ZoneSummaryStatsKeys = [
  'nhpi_pop_pct',
  'black_pop_pct',
  'white_pop_pct',


I: and add two_or_more_races_pop here

Will handle in separate PR

raphaellaude · 2024-11-19T04:24:06Z

backend/app/main.py

@@ -5,7 +5,7 @@
 from starlette.middleware.cors import CORSMiddleware
 from sqlalchemy.dialects.postgresql import insert
 import logging
-from sqlalchemy import bindparam
+from sqlalchemy import bindparam, func


Q: is func used here? I don't see it in the diff

raphaellaude · 2024-11-19T04:26:23Z

backend/app/sql/summary_stats_pop_totals.sql

@@ -0,0 +1,40 @@
+DROP FUNCTION IF EXISTS get_summary_stats_pop_totals;


H: This function isn't being used now, no? We can delete in favor of using the either get_summary_p1_totals or get_summary_p4_totals (and eventually others...)?

raphaellaude · 2024-11-19T04:27:15Z

backend/app/sql/summary_stats_pop_totals.sql

+    amin_pop BIGINT,
+    nhpi_pop BIGINT,
+    black_pop BIGINT,
+    white_pop BIGINT


H: Even though we should remove this function, we'll need to add two_or_more_races_pop to get_summary_p1_totals.

raphaellaude · 2024-11-19T04:30:52Z

pipelines/simple_elt/main.py

 if __name__ == "__main__":
    cli()
+
+
+def upsert_places_and_problems():


PP: Move above if __name__ == "__main__" but add raise NotImplementedError in the function body. Or just warnings.warn("Not implemented") or something

raphaellaude

lgtm

bailliekova and others added 24 commits September 11, 2024 10:09

available summary stat udf

d427ec6

migration to create metadata endpoint

f27a020

fix syntax errors

67f77d1

Merge branch 'main' into summary-stats

1e930c1

use correct udf name

1f19c18

Merge branch 'summary-stats' of https://github.com/districtr/district…

fb8b7fe

…r-v1 into summary-stats

fix multiple alembic heads

31c6257

draft place and problem types

8407beb

refactor tests

87c315f

add persistent session in case ever needed

8657f5a

if used it's then explicit

update place + problem types, migration; load data

74560c9

add model constraint

a7ca74d

mergearoni

08665cd

add func to update existing dmaps

66b048b

update districtr maps to add available summary stats

09adb45

functional p1 stat endpoint

d39f8a2

result available summary stats with document

0977336

summary stats

217adff

not fully reactive yet

bloink

143b411

update with total pop

becb81f

attempt to hash assignments but appears to always be one step behind...

fafeb1d

chart: show ideal pop + fix max

3cde336

dynamically set max based on data + ideal

5c657c3

set # colors based on target num districts

beef7eb

mariogiampieri temporarily deployed to pr-167 November 11, 2024 05:10 — with GitHub Actions Inactive

update typing on import script

ab2840c

mariogiampieri temporarily deployed to pr-167 November 11, 2024 05:26 — with GitHub Actions Inactive

roll back type change

73f890e

mariogiampieri temporarily deployed to pr-167 November 11, 2024 05:33 — with GitHub Actions Inactive

wrap in try/except

65494e6

mariogiampieri had a problem deploying to pr-167 November 16, 2024 14:25 — with GitHub Actions Failure

update migration dependencies

4de2f41

mariogiampieri temporarily deployed to pr-167 November 16, 2024 14:39 — with GitHub Actions Inactive

interstital port of load places and problems

38ca96f

mariogiampieri temporarily deployed to pr-167 November 16, 2024 15:21 — with GitHub Actions Inactive

mariogiampieri temporarily deployed to pr-167 November 16, 2024 15:31 — with GitHub Actions Inactive

mariogiampieri changed the title ~~Chart enhancements + broaching places and districtingProblems port over~~ Chart enhancements + stem of places and districtingProblems Nov 16, 2024

mariogiampieri changed the title ~~Chart enhancements + stem of places and districtingProblems~~ Chart enhancements + stub of places and districtingProblems Nov 16, 2024

mariogiampieri marked this pull request as ready for review November 16, 2024 15:52

nofurtherinformation reviewed Nov 18, 2024

View reviewed changes

mariogiampieri added 2 commits November 18, 2024 21:04

update based on comments

013bfff

Merge branch 'main' of https://github.com/districtr/districtr-v2 into…

f52775e

… feat/chart-enhancements

mariogiampieri had a problem deploying to pr-167 November 19, 2024 02:24 — with GitHub Actions Failure

mariogiampieri had a problem deploying to pr-167 November 19, 2024 02:45 — with GitHub Actions Failure

mariogiampieri had a problem deploying to pr-167 November 19, 2024 02:49 — with GitHub Actions Failure

remove db models

b7494f4

mariogiampieri had a problem deploying to pr-167 November 19, 2024 02:56 — with GitHub Actions Failure

mariogiampieri had a problem deploying to pr-167 November 19, 2024 03:10 — with GitHub Actions Failure

mariogiampieri temporarily deployed to pr-167 November 19, 2024 03:16 — with GitHub Actions Inactive

clear logging

2289dd0

mariogiampieri temporarily deployed to pr-167 November 19, 2024 03:17 — with GitHub Actions Inactive

mariogiampieri requested a review from raphaellaude November 19, 2024 03:24

raphaellaude requested changes Nov 19, 2024

View reviewed changes

cleanup

f535823

mariogiampieri temporarily deployed to pr-167 November 19, 2024 04:57 — with GitHub Actions Inactive

raphaellaude approved these changes Nov 19, 2024

View reviewed changes

mariogiampieri merged commit 69fb2d2 into main Nov 19, 2024
2 checks passed

mariogiampieri deleted the feat/chart-enhancements branch November 19, 2024 05:06

mariogiampieri deployed to pr-167 November 19, 2024 05:06 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chart enhancements + stub of `places` and `districtingProblems` #167

Chart enhancements + stub of `places` and `districtingProblems` #167

mariogiampieri commented Nov 11, 2024 •

edited

Loading

mariogiampieri commented Nov 16, 2024

nofurtherinformation left a comment

nofurtherinformation Nov 18, 2024

mariogiampieri Nov 19, 2024

nofurtherinformation Nov 18, 2024

nofurtherinformation Nov 18, 2024

mariogiampieri Nov 19, 2024

raphaellaude left a comment

raphaellaude Nov 19, 2024

raphaellaude Nov 19, 2024

raphaellaude Nov 19, 2024

raphaellaude Nov 19, 2024

raphaellaude Nov 19, 2024

raphaellaude Nov 19, 2024

raphaellaude Nov 19, 2024

raphaellaude Nov 19, 2024

raphaellaude Nov 19, 2024

raphaellaude left a comment

		@@ -0,0 +1,40 @@
		DROP FUNCTION IF EXISTS get_summary_stats_pop_totals;

Chart enhancements + stub of places and districtingProblems #167

Chart enhancements + stub of places and districtingProblems #167

Conversation

mariogiampieri commented Nov 11, 2024 • edited Loading

Description

Reviewers

Checklist

Screenshots (if applicable):

mariogiampieri commented Nov 16, 2024

nofurtherinformation left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raphaellaude left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raphaellaude left a comment

Choose a reason for hiding this comment

Chart enhancements + stub of `places` and `districtingProblems` #167

Chart enhancements + stub of `places` and `districtingProblems` #167

mariogiampieri commented Nov 11, 2024 •

edited

Loading