Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft delete DistrictrMap #183

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Soft delete DistrictrMap #183

merged 8 commits into from
Nov 18, 2024

Conversation

raphaellaude
Copy link
Collaborator

Description

  • Ahead of testing it would be nice to not have to delete DistrictMaps from the DB but rather soft delete them
  • This PR also cleans up the create_districtr_map_udf, which wasn't actually being applied! The extent logic from what I can tell is valid but adding it in causes all sorts of trouble with the tests

Reviewers

Checklist

  • Added/Updated related documentation (if applicable).
  • Added/Updated related unit tests (if applicable).

Screenshots (if applicable):

@raphaellaude raphaellaude self-assigned this Nov 18, 2024
@raphaellaude
and this
d8faa3e 
its weird because the tests run fine locally...
@raphaellaude
update reqs
11bb51f 
mostly to get rid of test warnings fixed with fastapi 0.114.0
nofurtherinformation
nofurtherinformation approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@nofurtherinformation nofurtherinformation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@raphaellaude raphaellaude merged commit 60153d5 into main Nov 18, 2024
1 check passed
@raphaellaude raphaellaude deleted the soft-delete-districtrmap branch November 18, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nofurtherinformation nofurtherinformation nofurtherinformation approved these changes

@mariogiampieri mariogiampieri Awaiting requested review from mariogiampieri

Assignees

@raphaellaude raphaellaude

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphaellaude @nofurtherinformation