Fixes issues #108 and #124. #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tox pep8,py27,py36` now passes.
dixudx
reviewed
Feb 4, 2020
| @@ -32,6 +32,11 @@ class RTCClient(RTCBase): | |||
| the url ends with 'jazz', otherwise to `False` if with 'ccm' | |||
| (Refer to issue #68 for details) | |||
| :type ends_with_jazz: bool | |||
| :param attribute_map: (optional) Dictionary mapping RTC attributes to | |||
There was a problem hiding this comment.
Actually I don't get what this attribute_map is for.
If you want to know all the alias, you can refer to field_alias. See this link.
There was a problem hiding this comment.
attribute_map does two things:
- It allows overriding the alias that is automatically created in
FieldBase.__initializeFromRaw. - It is the mechanism for forcing the inclusion of an attribute with a "." in the name, which is the specific fix for issue Properties with "." in the name are not accessible #108
There was a problem hiding this comment.
Hello. Just following up. Is there anything else I can do to move this along?
There was a problem hiding this comment.
Can field_alias in this link be used, instead of having a new attribute_map ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox pep8,py27,py36now passes.