Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prepare develop-4 for Django CMS 4.2 #7913

Merged
merged 9 commits into from
Jun 28, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented May 8, 2024

Description

This PR:

  • Creates the 4.2.0 release note document
  • Removes functionality marked for removal in django CMS 4.2
  • Runs pyupgrade and django-upgrade to versions 3.10 and 4.2, respectively

After merging this RP, bug fixes need to be backported to the release/4.1.x branch.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from marksweb May 8, 2024 11:17
@fsbraun fsbraun marked this pull request as ready for review May 8, 2024 18:30
@fsbraun fsbraun added the 4.2 label May 8, 2024
Copy link
Sponsor Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a chunk more. So this is like a "save your progress"

@@ -12,21 +12,15 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ 3.9, '3.10', '3.11', '3.12' ] # latest release minus two
python-version: [3.9, '3.10', '3.11', '3.12',] # latest release minus two
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking about versions. Python 3.13 is in beta ahead of a launch in October and django 5.1 is in alpha ahead of August release.

Maybe easier in a new PR, which I might have a look at this morning. But feels like testing against upcoming versions needs adding.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a great idea.

@fsbraun fsbraun merged commit 538ae59 into django-cms:develop-4 Jun 28, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants