Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach tax_number clean method's validation error #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions plans/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,22 +163,17 @@ def clean_tax_number(tax_number, country):
number = tax_number[len(country):]

if not vatnumber.check_vat(country + number):
# This is a proper solution to bind ValidationError to a Field but it is not
# working due to django bug :(
# errors = defaultdict(list)
# errors['tax_number'].append(_('VAT ID is not correct'))
# raise ValidationError(errors)
raise ValidationError(_('VAT ID is not correct'))
raise ValidationError({'tax_number': _('VAT ID is not correct')})

return tax_number
else:
return ''


# FIXME: How to make validation in Model clean and attach it to a field? Seems that it is not working right now
# def clean(self):
# super(BillingInfo, self).clean()
# self.tax_number = BillingInfo.clean_tax_number(self.tax_number, self.country)
def clean(self):
super(BillingInfo, self).clean()
self.tax_number = BillingInfo.clean_tax_number(self.tax_number, self.country)

class UserPlan(models.Model):
"""
Expand Down