Support free plans. #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes django-getpaid#24 Plans without pricings will be `plan.is_free: true`. Switching to these plans causes the userplan have it's expiry cleared. Since there's no expiry set, the standard plan change process doesn't make sense, so the plan table is adjusted to present the standard plan order links rather than plan change links.
|
Are there any plans to merge this? |
|
@brentc This is a good idea. after ~4 years |
Alir3z4
requested changes
May 5, 2018
|
@Alir3z4 I hope, that everything here got merged, so you can close this. |
Romamo
pushed a commit
to Romamo/django-plans
that referenced
this pull request
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Plans without pricings will be
plan.is_free(): true. Switching to theseplans causes the userplan have it's expiry field set to
NoneSince there's no
userplan.expiry, the standard plan change process doesn'tmake sense, so the plan table is adjusted to present the standard plan
order links rather than plan change links.
Note: I have not implemented the presentation layer/tagging suggestion
from #24, but I think the handling of the free plan in the plan table may be
sufficient for now (for our purposes it is).