Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3 fixes for other submodules, some pep8 #67

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

python 3 fixes for other submodules, some pep8 #67

wants to merge 7 commits into from

Conversation

kavdev
Copy link
Contributor

@kavdev kavdev commented Aug 11, 2015

No description provided.

@kavdev kavdev mentioned this pull request Aug 11, 2015
@aburgel
Copy link
Member

aburgel commented Aug 13, 2015

this looks like a less extensive set of changes than #66. i don't use python 3 so i don't know what changes are necessary. can you let me know whether i should merge both PRs?

@kavdev
Copy link
Contributor Author

kavdev commented Aug 14, 2015

The changes in #66 uses 2to3 to automatically alter the code to work with python 3, including 3.0 and 3.1.

  1. It's become convention to target 3.2+ to avoid dealing with the screwy api of 3.0 and 3.1
  2. Some of the changes made aren't backwards compatible.

That being said I missed a few things like iteritems() calls. I'll update this PR tomorrow.

@kavdev
Copy link
Contributor Author

kavdev commented Oct 21, 2015

should be all set. sorry it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants