✨ Rework the community page to feature more modern resources more clearly #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @coderanger, thanks for your PR. Good set of changes, happy for it to go in with some tidy ups and tests 🚢 Could you please add a before screenshot as well? |
Current desktop screenshot
As for tests, happy to add some but not sure what since there's no logic changes, this is only copy :) |
|
I was referring to a UX QA, and maybe testing on different mobile devices.
…On Fri, Oct 21, 2022, 12:01 AM Noah Kantrowitz ***@***.***> wrote:
Current desktop screenshot
[image: Screenshot 2022-10-20 at 16-00-31 Django Community Django]
<https://user-images.githubusercontent.com/128243/197074932-b6d5ea7f-a17b-4f37-9269-a5d7595edfff.png>
As for tests, happy to add some but not sure what since there's no logic
changes, this is only copy :)
—
Reply to this email directly, view it on GitHub
<#1257 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMKKLVI3JF3C3XDVJUD3UTWEHFNHANCNFSM6AAAAAARKSKZUA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Ahh fair :D I posted a mobile screenshot for iOS 12/13 width just using Firefox's dev tools, but will see if I can get my phone to load the dev site directly for a more real test. |
Some real iOS screenshots
|
|
I quite like this, FWIW. 🙂 |
|
Anything I can do to help move this along? |
|
This looks great, @coderanger ! Thank you for all your work! 🙏🏼 Can you please rebase your PR agains the current main branch? Please tag me once you're done and I'll do a few tests before merging this in. |
cgl
force-pushed
the
community-cta
branch
2 times, most recently
from
c2d72ab
to
960c7ab
Compare
sabderemane
force-pushed
the
community-cta
branch
from
960c7ab
to
6170945
Compare
cgl
force-pushed
the
community-cta
branch
2 times, most recently
from
539066e
to
3b20b85
Compare
for more information, see https://pre-commit.ci
cgl
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The community page centers older resources like the mailing list and IRC channel, which are no longer the best ways to participate in most parts of our community. You can skip down to the screenshots below but that main change is making a 2x2 grid of the primary calls to action to streamline those, as well as updates to the sidebar to remove deprecated or irrelevant content and generally update things.
Before (desktop view):
After:
Desktop screenshot
Mobile screenshot