Fixed Issue Menu button is not a button #1234 #1400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabderemane
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Hi @faisal1025 , thank you for your contribution! ✨
Can you also provide screenshots before and after your changes ?
I feel like the style you applied it's not taken in consideration as there are a border around the menu with is not the case currently.
| @@ -12,7 +12,7 @@ define([ | |||
| init: function(){ | |||
| var self = this; | |||
| self.menu.addClass('nav-menu-on'); | |||
| self.button = $('<div class="menu-button"><i class="icon icon-reorder"></i><span>Menu</span></div>'); | |||
| self.button = $('<div class="menu-button"><button class="icon icon-reorder" style="background-color: transparent; color: white; border: none;"></button><span>Menu</span></div>'); | |||
There was a problem hiding this comment.
style should be on the css file corresponding to the element (_style.scss) and not inline like this
6 tasks
|
Closed by #1418 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue has been fixed the menu button is now focusable on pressing
tabfrom the keyboard.The menu button is focusable from the keyboard by pressing the Tab button.
We can open the options from the keyboard by pressing Enter button