Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade django packages for in preparation for 4.2 upgrade #1436

Closed

Conversation

sarahboyce
Copy link
Contributor

@sarahboyce sarahboyce commented Nov 29, 2023

Summary

I want to start the work to migrate from 3.2 to 4.2. The first step I see is upgrading our packages.
#1437

Major upgrades included:

django-contact-form 1.9 -> 2.1

Migration guide: https://django-contact-form.readthedocs.io/en/latest/upgrade.html#changes-between-django-contact-form-1-x-and-2-x

Impacted by rename of contact_form to django_contact_form

django-recaptcha 3.0.0 -> 4.0.0

Migration guide: https://github.com/django-recaptcha/django-recaptcha/blob/main/CHANGELOG.md#400-2023-11-14

Impacted by renamed of captcha to django_recaptcha

django-money 2.1.1 -> 3.4

We're impacted by moneyed.localization removal.
format_money is now in moneyed.l10n.format_money
py-moneyed has upgraded to version 2 and the way we customised localisation before is no longer available.
I believe the main impact is this PR: https://github.com/django-money/django-money/pull/638/files
Added a test and simplified the approach.

@sarahboyce sarahboyce force-pushed the upgrade-django-packages-for-4-2 branch from a60fa5b to 5b95e19 Compare November 29, 2023 10:31
@sarahboyce sarahboyce force-pushed the upgrade-django-packages-for-4-2 branch from ad29b22 to e2b3bb8 Compare November 29, 2023 11:22
@pauloxnet
Copy link
Member

Great proposal @sarahboyce, it's something I've wanted to do for a long time but never found the time to do.
Could it be safer to update individual packages in different PRs? And finally, update Django?

@sarahboyce
Copy link
Contributor Author

Great proposal @sarahboyce, it's something I've wanted to do for a long time but never found the time to do. Could it be safer to update individual packages in different PRs? And finally, update Django?

Good idea 👍 I will split this out tomorrow

Note: we will get blocked by this soon: brutasse/django-push#28
But I will get everything else done out the way

@pauloxnet
Copy link
Member

Note: we will get blocked by this soon: brutasse/django-push#28 But I will get everything else done out the way

Dependence on that project has always been problematic even for updates in the past.

If the maintainer is not responsive, we might think about forking the project and bringing it to jazzaband or copying the code that interests you.

@sarahboyce
Copy link
Contributor Author

Ok all the needed ones are in seperate PRs, I will close this as any extra changes is probably noise and small deployments might be wise.
Note: #1438 is already merged.

If the maintainer is not responsive, we might think about forking the project and bringing it to jazzaband or copying the code that interests you.

Both of these options work for me 🤔 I will try to do a polite message on the PR and see where we get to

@sarahboyce sarahboyce closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants