-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #1435 -- hamburger tab key focus issue fixed #1451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Bhagyarsh!
Thank you for your contribution.
This seems to flip the ordering of the dark-mode toggle with the hamburger menu option for me 🤔 albeit your screenshots do not show this.
I'm checking this on Chrome Version 120.0.6099.109 (Official Build) (arm64)
on macOS. Can you please let me know which browser are you testing this on?
Before changes:
After Changes:
Hi Sanyam, Thanks for looking into it! I tested on the same Chrome version Could it be a cache thing on your side? Give it a shot after clearing and let me know if it's still acting up. |
Hi @CuriousLearner , |
Hi @Bhagyarsh and thanks for this PR! I took a look a it on my local version (using firefox) and your approach does seem to work (I did have to run However I'm a bit hesitant about adding more complexity to the HTML. Instead I tried an alternative approach and used Thanks! ✨ |
Hi @Bhagyarsh Sorry, I didn't get a notification for your earlier comment. I'll take a look at this soon. |
Hi, I ended up merging this feature in #1523. Thanks for being part of this team effort and working on improving the website 🚀 |
Issue #1435
Screenshots for reference
Before:
After: