Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make top_radius the top for PositionCone3dModifier #96

Closed
wants to merge 1 commit into from
Closed

Make top_radius the top for PositionCone3dModifier #96

wants to merge 1 commit into from

Conversation

NiseVoid
Copy link
Contributor

I assume the top_radius is meant to be at the higher Y coordinate, this PR makes it so that that's true.

@NiseVoid
Copy link
Contributor Author

.init(PositionCone3dModifier {
    height: 30.,
    top_radius: 0.,
    base_radius: 5.,
    dimension: ShapeDimension::Volume,
    speed: Value::Single(0.),
})

now results in:

@NiseVoid
Copy link
Contributor Author

As discussed in #95, a change to the fieldname top_radius is probably the better solution to the confusion around top_radius facing down.

@NiseVoid NiseVoid closed this Nov 30, 2022
@djeedai djeedai added the A - modifiers Change related to modifiers label Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A - modifiers Change related to modifiers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants