fix(src): resolve exclude paths

[antoineauger]

Pull Request Check List

Resolves: #issue-number-here

• Adapted tests for changed code.
• Updated documentation for changed code.

Closes #1028

🛠️ with ❤️ by Siemens

/cc @nejch

[netlify]

✅ Deploy Preview for djlint canceled.

Name	Link
🔨 Latest commit	1ccc345
🔍 Latest deploy log	https://app.netlify.com/sites/djlint/deploys/67409cb006ec170008758b99

[antoineauger]

⚠️ This PR would theoretically be a breaking change since previously-define exclude patterns might not work with the new Path resolve.

The documentation seems to already be up-to-date with the behavior of this MR though:

  --exclude TEXT                  Override the default exclude paths.
  --extend-exclude TEXT           Add additional paths to the default exclude.

Let me know what you think, I will be happy to adapt/refactor if needed.

[nejch]

Not sure but maybe this could also just be a comprehension :)

Suggested change

	exclude_paths = []
	for p in self.exclude.split("|"):
	exclude_paths.append(Path(p.strip().replace("\\.", ".")).resolve())
	return exclude_paths
	return [Path(p.strip().replace("\\.", ".").resolve() for p in self.exclude.split("|")]

[monosans]

Or even better a for loop with yield (generator)

[antoineauger]

I made another attempt and pushed 1ccc345

[monosans]

Thank you!

[monosans]

Hi, I have reverted this PR as it is a breaking change and I think it should be reworked. The old behavior was more correct imo.

[antoineauger]

Hi @monosans, sorry to read that.

as it is a breaking change

Yes, I mentioned it in #1034 (comment).

I think it should be reworked

I just saw #1047 and I might have overlooked some cases, sorry about that. But given that this exclude is a pretty standard option present in a lot of linters, I'm sure that this can be properly solved without too much hacking 😅

The old behavior was more correct imo.

I tend disagree on this point.

If --exclude=build is passed, all paths containing *build* will be ignored, even if the string only partially match a parent directory. For instance, /builds/template.html.j2, /build-my-template/template.html.j2, etc. will always be ignored no matter where djlint is ran.

This causes major problems for people in CI with GitLab for instance (our case).

[liambuchanan]

Whatever the solution ends up being here, it seems like it should probably use a new param name. Changing behavior for the existing param will cause issues for lots of users that have built workflows on the existing behavior. That's how I ended up here.