Repository navigation
chore(release): v1.9.0 - #262
Merged
Merged
Conversation
Bump the plugin header, MAESTRO_VERSION, Stable tag and package version to 1.9.0. 1.8.0 was never tagged, so the 1.9.0 changelog and upgrade notice carry its changes, renamed to visibility groups, alongside "All other roles", preview as a role and the desktop and mobile polish through #260. Regenerate the POT, which still had the hiding-profile strings, and record the cut in STATE and the D5 row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tY8BSUE4tF9wo8m1hx4qW
13 of 15 tasks
…elease Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tY8BSUE4tF9wo8m1hx4qW
#265 makes each phone tool group scroll sideways and keeps the open tool highlighted, so two older checks failed on purpose-built behavior: - menu-width's narrow-toolbar test measured every button's right edge, including ones scrolled out of a group. It now measures the groups that clip them and checks that the page itself does not scroll sideways. - the touch-hover test read the Visibility button while its popover was open. It now closes the popover with a tap outside, so it still checks that a tap leaves no hover accent behind. The 1.9.0 changelog gains the dialog, group-deletion, tool-switching and icon fixes, and the readme and user guide call Preview as the screen button. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tY8BSUE4tF9wo8m1hx4qW
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Dan · project thread
Cuts 1.9.0 from main after #260 (
d34a576), plus #265's iPhone fixes, which Dan approved for the 1.9 release. Uses the current toolbar interface; the selected-row prototype (#261) is not included.Why 1.9.0, not 1.8.0
#242 bumped main to 1.8.0, but 1.8.0 was never tagged or released (latest release is v1.7.0). Since then main gained "All other roles" (Phase 29), preview as a role (Phase 30) and the desktop and mobile polish (#256 to #260), which is the v1.9 Client-Site Workflow scope minus Phase 31. Following the D5 recommendation, this ships 1.9.0 now and leaves export/import (#263) for a later release. The changelog folds the unreleased 1.8.0 notes into the 1.9.0 entry, so WordPress.org users going from 1.7.0 see one list.
Changes
MAESTRO_VERSION,Stable tagandpackage.json/lockfile: 1.8.0 to 1.9.0.readme.txtchangelog and upgrade notice for 1.9.0, using "visibility groups" throughout (the old 1.8.0 entry still said "hiding profiles").menu-widthnarrow-toolbar now measures the scrolling tool groups and checks that the page does not scroll sideways.touch hovercloses the Visibility popover before it checks that a tap leaves no hover accent behind. Both of those checks and the 320px case pass locally.languages/maestro-menu-editor.potregenerated (WP-CLI 2.12,--skip-js)..planning/STATE.mdand the D5 row inROADMAP.mdrecord the cut.After merge
Tag the merge commit
v1.9.0.release.ymlchecks the tag against the header and Stable tag, builds the ZIP and deploys to WordPress.org. Merging also lands #265's commits, so #265 can be closed. Real iPhone/iPad acceptance is Dan's.🤖 Generated with Claude Code
https://claude.ai/code/session_012tY8BSUE4tF9wo8m1hx4qW