Skip to content

fix: keep Settings above the toolbar when Review file grows it; link public tester guide - #274

Merged
dknauss merged 2 commits into
mainfrom
claude/project-thread-vnxv14
Oct 27, 2026
Merged

dknauss merged 2 commits into
mainfrom
claude/project-thread-vnxv14

Conversation

@dknauss

@dknauss dknauss commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Requested by Dan · project thread

Summary

  • Bug: pressing Review file in Settings → Export/import adds the report and the Import button. The dialog stayed where it had opened, so it ran down over the editing toolbar and off the bottom of the screen (found while capturing screenshot 7 in docs: bring readmes, docs and screenshots up to v1.10.0 #273).
  • Fix: assets/maestro.js adds maestro-settings-popover to the ResizeObserver grows list, the same treatment the Visibility and visibility groups dialogs already get. When the dialog grows it re-anchors upward, and once it reaches the top of the screen it scrolls inside itself.
  • Test: a new check in config-transfer.spec.ts at 1440×900. After Review file, the dialog has to end above the gear that opened it, Import has to stay above the gear, and the page must not scroll.
  • Capture spec: the resize-event workaround I added in docs: bring readmes, docs and screenshots up to v1.10.0 #273 is removed. Screenshot 7 comes out the same without it, so the PNG is unchanged.
  • README: the prototype section's tester guide link now points to the public page at https://newlocalmedia.github.io/guides/maestro-prototype-testing/, and the copy on the prototype branch stays linked alongside it. This went into this PR because docs: bring readmes, docs and screenshots up to v1.10.0 #273 had already merged.

Type of change

  • Bug fix
  • Feature
  • Documentation
  • Tooling / CI
  • Release / packaging

Verification

  • npm run test:js
  • npm run check:doc-links
  • npm run test:e2e, partial, against a local WordPress 7.1.3 + SQLite site:
    • The new check fails without the fix and passes with it.
    • The menu-width, dialog-close, dialog-standard and role-preview specs give the same results before and after the fix. In both runs, one real-user role-parity login timed out. It was a different role each time, which points to the local environment.
    • The other config-transfer specs need wp-env's cli container, which I can't run here, so CI covers those.
  • composer test:unit (CI)
  • npm run test:php (CI)

Notes

🤖 Generated with Claude Code

https://claude.ai/code/session_01WPtgA2NT1r5eQWXVmozdS6

Reviewing an import file adds a report and the Import button to the
Settings dialog. It kept the place it opened at, so it ran down over the
editing toolbar and off the bottom of the screen. Re-anchor it on resize
like the Visibility and visibility groups dialogs, so it grows upward
and scrolls inside itself once it reaches the top. The directory
screenshot capture no longer needs its resize workaround.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WPtgA2NT1r5eQWXVmozdS6
@dknauss dknauss self-assigned this Oct 27, 2026
@dknauss dknauss changed the title fix: keep Settings above the toolbar when Review file grows it fix: keep Settings above the toolbar when Review file grows it; link public tester guide Oct 27, 2026
@dknauss
dknauss marked this pull request as ready for review October 27, 2026 23:01
@dknauss
dknauss merged commit 46bce57 into main Oct 27, 2026
16 of 17 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T23:02:23.800039Z 209fbd3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dknauss
dknauss deleted the claude/project-thread-vnxv14 branch October 27, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants