Repository navigation
fix: keep Settings above the toolbar when Review file grows it; link public tester guide - #274
Merged
Merged
Conversation
Reviewing an import file adds a report and the Import button to the Settings dialog. It kept the place it opened at, so it ran down over the editing toolbar and off the bottom of the screen. Re-anchor it on resize like the Visibility and visibility groups dialogs, so it grows upward and scrolls inside itself once it reaches the top. The directory screenshot capture no longer needs its resize workaround. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPtgA2NT1r5eQWXVmozdS6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPtgA2NT1r5eQWXVmozdS6
dknauss
marked this pull request as ready for review
October 27, 2026 23:01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Dan · project thread
Summary
assets/maestro.jsaddsmaestro-settings-popoverto the ResizeObservergrowslist, the same treatment the Visibility and visibility groups dialogs already get. When the dialog grows it re-anchors upward, and once it reaches the top of the screen it scrolls inside itself.config-transfer.spec.tsat 1440×900. After Review file, the dialog has to end above the gear that opened it, Import has to stay above the gear, and the page must not scroll.Type of change
Verification
npm run test:jsnpm run check:doc-linksnpm run test:e2e, partial, against a local WordPress 7.1.3 + SQLite site:clicontainer, which I can't run here, so CI covers those.composer test:unit(CI)npm run test:php(CI)Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01WPtgA2NT1r5eQWXVmozdS6