Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include all files in the pack, that is published #29

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

Totto16
Copy link
Contributor

@Totto16 Totto16 commented Oct 24, 2024

Fixes #28

The current package on npm is a stub and only has two files: here
image

This was introduced in #25

To see this error run npm run build:ngx-loading-buttons && npm pack dist/ngx-loading-buttons/ before and after this PR.

You can see before this, it only packs two files, after this it packs all necessary files.

Another error from #25 is, that there is no file ./styles.css in the dist folder, only one in ./src/styles.css.

I wonder how #25 got merged 😓 😂 Feel free to test this extensively and in a real world scenario, than you can see that this works, and the previous state not 😓

@dkreider dkreider merged commit 64e3b80 into dkreider:main Oct 24, 2024
@dkreider
Copy link
Owner

@Totto16 I can't thank you enough! This has been on my bucket list for such a long time.

@Totto16 Totto16 deleted the fix_files_in_packed_archive branch October 24, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to import MatBasicSpinnerDirective in Angular v18.
2 participants