Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10605 - Make File.byLine usable in @safe contexts #10622

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

0xEAB
Copy link
Member

@0xEAB 0xEAB commented Jan 17, 2025

Implements #10605.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 17, 2025

Thanks for your pull request, @0xEAB!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10622"

@0xEAB
Copy link
Member Author

0xEAB commented Jan 17, 2025

Given that this only implements the other half of #10605, I’m not sure whether the commit message (and PR title) should say “Fix #10605”. Let me know, in case you want me to add the prefix.

@0xEAB 0xEAB linked an issue Jan 17, 2025 that may be closed by this pull request
@rikkimax
Copy link
Contributor

If this PR should close the ticket, add it.

@0xEAB
Copy link
Member Author

0xEAB commented Jan 17, 2025

If this PR should close the ticket, add it.

Done. Already had it in the commit message’s “body”, but now I’ve added it to the headline.

@0xEAB 0xEAB changed the title Make File.byLine usable in @safe contexts Fix #10605 - Make File.byLine usable in @safe contexts Jan 17, 2025
@0xEAB
Copy link
Member Author

0xEAB commented Jan 17, 2025

std/stdio.d(2251:9)[warn]: same visibility attribute used as defined on line 2216.

Oh come on, D-Scanner, that one was for readability. But if you insist, I’ll downgrade that one for you…

@dlang-bot dlang-bot merged commit 1b24204 into dlang:master Jan 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

byLine and byLineCopy should be safe
5 participants