Create a cleanup handler for the varnish cache to provide 'ban' functionality #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
changed the title
donaldgray
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
LGTM; couple of comments but mostly around unused vars + gh action versions.
One thought - it might be good to allow this to work if INCOMING_QUEUE is missing. E.g. if we scale out for 4hours to cope with a known load we might want additional varnish instances running without worrying about bans. (maybe create a ticket for this new behaviour rather than add to this PR)
| uses: docker/setup-buildx-action@v2 | ||
| with: | ||
| driver-opts: | | ||
| image=moby/buildkit:v0.10.6 |
There was a problem hiding this comment.
I'm not sure if this is required any longer, I'll take a note to test removing from Protagonist. It was related to a ghcr/buildkit issue from a few months ago (docker/build-push-action#761 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
This pull request adds a python script that listens to an SQS queue for deletions and then actions a
banrequest on a varnish cache using tags. This script can be run separately, in it's own docker container, or within the varnish container itself