Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varnish cache_file name is optional #8

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

donaldgray
Copy link
Member

@donaldgray donaldgray commented May 8, 2024

Main change was to introduce VARNISH_CACHE_FILE envvar, which is optional. Previously VARNISH_CACHE_FOLDER was used as location and varnish_cache.bin as name for file. However, by making VARNISH_CACHE_FILE optional we can just specify a folder and Varnish will create a file of it's own.

From varnish docs:

The ‘path’ parameter specifies either the path to the backing file or the path to a directory in which varnishd will create the backing file.

Other changes:

  • Update base image to more up to date Ubuntu version
  • Change order of some statements in dockerfile to prevent need to install pypi requirements if start.sh updated
  • Update start.sh to allow it to run without cleanup_handler if no INCOMING_QUEUE specified.
  • Update boto requirements as docker image failing to build.
  • Moved requirements that are only for testing to a separate test_requirements.txt to avoid installing on docker image.

@donaldgray donaldgray changed the title All varnish to set varnish file name Allow varnish to set varnish file name May 9, 2024
@donaldgray donaldgray changed the title Allow varnish to set varnish file name Varnish cache_file name is optional May 9, 2024
@donaldgray donaldgray merged commit 542497f into master May 9, 2024
2 checks passed
@donaldgray donaldgray deleted the feature/cache_folder branch May 9, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant