-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create asset modified cleanup handler #882
Merged
JackLewis-digirati
merged 23 commits into
main
from
feature/assetModifiedCleanupHandler
Jul 15, 2024
Merged
Create asset modified cleanup handler #882
JackLewis-digirati
merged 23 commits into
main
from
feature/assetModifiedCleanupHandler
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with modified notification sending before like after
JackLewis-digirati
changed the title
Feature/asset modified cleanup handler
Create asset modified cleanup handler
Jul 12, 2024
donaldgray
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as I'd already approved #856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #430
links WDLS-507
This PR reimplements work done on #841 as well as implementing the work required by the asset modified cleanup handler.
It includes a new appsettings section:
And
DryRun
determines whether the application should actually remove files/db entries and isfalse
by defaultEngineRoot
is used for setting the engine URI, which is used by the cleanup handler to retrieve details encoding presets from engineAdditional changes in this PR includes allowing the cleanup handler to listen to multiple SQS queues and an additional endpoint added to the engine for retrieving a dictionary of presets
UpdateNotificationQueueName
details the name of the queueNOTE: this PR has previously been approved under #856 when targeting the
develop
branch. This PR rebases and retargets the release tomain
.