Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create asset modified cleanup handler #882

Merged
merged 23 commits into from
Jul 15, 2024

Conversation

JackLewis-digirati
Copy link
Contributor

@JackLewis-digirati JackLewis-digirati commented Jul 11, 2024

Resolves #430
links WDLS-507

This PR reimplements work done on #841 as well as implementing the work required by the asset modified cleanup handler.

It includes a new appsettings section:

"AssetModifiedSettings": {
  "DryRun": false,
  "EngineRoot": "https://localhost:7014"
},

And

"UpdateNotificationQueueName": "dlcsspinup-update-notification"

DryRun determines whether the application should actually remove files/db entries and is false by default
EngineRoot is used for setting the engine URI, which is used by the cleanup handler to retrieve details encoding presets from engine

Additional changes in this PR includes allowing the cleanup handler to listen to multiple SQS queues and an additional endpoint added to the engine for retrieving a dictionary of presets

UpdateNotificationQueueName details the name of the queue

NOTE: this PR has previously been approved under #856 when targeting the develop branch. This PR rebases and retargets the release to main.

@JackLewis-digirati JackLewis-digirati marked this pull request as ready for review July 11, 2024 16:21
@JackLewis-digirati JackLewis-digirati requested a review from a team as a code owner July 11, 2024 16:21
@JackLewis-digirati JackLewis-digirati changed the title Feature/asset modified cleanup handler Create asset modified cleanup handler Jul 12, 2024
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as I'd already approved #856

@JackLewis-digirati JackLewis-digirati merged commit de96fef into main Jul 15, 2024
9 checks passed
@JackLewis-digirati JackLewis-digirati deleted the feature/assetModifiedCleanupHandler branch July 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete no-longer required delivery artifacts
2 participants