Open
Conversation
- Used by Sake, and PotionSatchel had code to specifically ignore PotionType.UNCRAFTABLE - Changed to a Mundane Potion, which may have unintended consequences (by being able to be converted in other recipes) - Added new namespace "id" to be able to specifically recognize Sake. If the already existing namespace "key" was used, it would need more changes (such as inheriting Consumable in order to be able to be right-clicked)
dlee13
reviewed
Apr 30, 2025
src/main/java/com/klin/holoItems/collections/gen0/suiseiCollection/items/Comet.java
Outdated
Show resolved
Hide resolved
- It was misleading due to usage of Set. The readded code is needed as a filter to rayTrace in order for Piercing to work
Contributor
Author
|
One thing that I really didn't bring back was the sinusoidal movement on Y axis (old Comet moved like Also, old Comet movement was smoother (less choppy). This is very noticeable when using /tick rate below 20 I haven't figured out if there's a way to add interpolation when the axe moves forward |
dlee13
reviewed
May 1, 2025
src/main/java/com/klin/holoItems/collections/gen0/suiseiCollection/items/Comet.java
Outdated
Show resolved
Hide resolved
Owner
I believe you're supposed to set the translation once and then the display entity will move every tick with interpolation automatically applied in the client side. |
- Fixed initial position being different depending on player's angle, by using Translation - Moved initialization to a Consumer, so it is set before a game tick. This fixes entity dot in minimap in the first tick - Fixed offhand slant
- Animation was choppy, due to use of teleport(). Fixed by using Translation. - Note: changed raytracing to use the normalized vector instead of x3 speed vector. This didn't change anything in testing.
Contributor
Author
|
Looks good to me now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.