Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1672-moves filesystem source #1731

Closed
wants to merge 27 commits into from
Closed

1672-moves filesystem source #1731

wants to merge 27 commits into from

Conversation

rudolfix
Copy link
Collaborator

Description

  1. keeps example pipelines and runs them in tests
  2. places tests in tests/load/sources/ because they depend on bucket configs that are available in load
  3. uses existing util functions and fixtures

willi-mueller and others added 27 commits August 22, 2024 17:10
@willi-mueller
copies rest_api source code and test suite, adjusts imports
120e413
@willi-mueller
integrates rest_client/conftest.pi into rest_api/conftest.py. Fixes i…
c012840 
…ncompatibilities except for POST request (/search/posts)
@willi-mueller
integrates POST search test
d7ffac7
@willi-mueller
do no longer skip test with typed dict config
d1ccb19
@willi-mueller
reuses tests/sources/helpers/rest_client/conftest.py in tests/sources…
5b379b9 
…/rest_api
@willi-mueller
checks off TODO
3d5990f
@willi-mueller
formats rest_api code according to dlt-core rules
e8c5ba3
@willi-mueller
fixes typing errors where optional field was required
802c124
@willi-mueller
fixes type errors except for test_configurations.py
4b3d751
@willi-mueller
fixes more type errors
b4a4503
@willi-mueller
fixes more type errors
91d47c5
@willi-mueller
fixes graphlib import error
16cc7ca
@willi-mueller
fixes more type errors and formats code
626e021
@willi-mueller
fixes last type errors
6ad8e06
@willi-mueller
moves latest changes from rest_api into core (687e7ddab3a95fa62158474…
090bc15 
…1af543e561147ebe3). Formats and lints entire rest API
@willi-mueller
adds new files from 687e7ddab3a95fa621584741af543e561147ebe3, starts …
d2baf9c 
…to reorganize test suite
@willi-mueller
modularizes rest_api test suite
f57bf66
@willi-mueller
formats imports
f36a146
@willi-mueller
updates signature of Paginator.update_state()
4de267f
@willi-mueller
formats code
1e958ae
@willi-mueller
attempt to make duckdb a minimal dependency by removing it from extras
6b7e670
@willi-mueller
Revert "attempt to make duckdb a minimal dependency by removing it fr…
8d2f1b8 
…om extras"

This reverts commit 6b7e670.
@willi-mueller
moves source test suite after duckdb is installed
c99e809
@willi-mueller
fixes Windows tests
b9a85b9
@rudolfix
adds copy sig for transformers
55b02dc
@rudolfix
rearranges old sources.filesystem
f50dc8c
@rudolfix
moves filesystem source with tests and examples
1fb3773
@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label Aug 22, 2024
@rudolfix rudolfix self-assigned this Aug 22, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 1fb3773
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66c79d8940f8fa0008e87dc6
😎 Deploy Preview https://deploy-preview-1731--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rudolfix rudolfix closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willi-mueller willi-mueller Awaiting requested review from willi-mueller

@sh-rp sh-rp Awaiting requested review from sh-rp

Assignees

@rudolfix rudolfix

Labels
sprint Marks group of tasks with core team focus at this moment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudolfix @willi-mueller