#2020 #2151 - fixes dbt 1.8.6 and arrow dict types #2175
Merged
+56
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudolfix
force-pushed
the
fix/2020-2151-fixes-dbt-arrow
branch
from
8609fe8 to
a0100ce
Compare
jorritsandbrink
approved these changes
Dec 23, 2024
| @@ -135,15 +128,10 @@ def run_dbt_command( | |||
| runner_args = (global_args or []) + [command] + args # type: ignore | |||
|
|
|||
| with dbt.logger.log_manager.applicationbound(): | |||
| try: | |||
There was a problem hiding this comment.
Looks like with this change we're not supporting dbt<1.5 anymore. We could write a note in the docs that 1.5.2 (looking at test_runner_dbt_versions.py) is the minimum tested/supported version.
There was a problem hiding this comment.
right! the fact is we do not support <1.5 for a long time already...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #2151
fixes #2020