Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unifies handling of naive datetime for arrow and object incrementals #2184

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

rudolfix
Copy link
Collaborator

@rudolfix rudolfix commented Jan 1, 2025

Description

unifies handling of naive datetime for arrow and object incrementals

Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 9ef9b9e
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/67759a193371d40008f1357f

@rudolfix rudolfix marked this pull request as ready for review January 2, 2025 09:12
@rudolfix rudolfix self-assigned this Jan 2, 2025
@rudolfix rudolfix requested a review from sh-rp January 2, 2025 09:18
Copy link
Collaborator

@sh-rp sh-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sh-rp
Copy link
Collaborator

sh-rp commented Jan 6, 2025

Maybe one note: if older versions of connector-x depended on this, maybe we should bump the min version? Or add a warning in the docs? I don't know how serious this problem was before.

@rudolfix
Copy link
Collaborator Author

rudolfix commented Jan 8, 2025

@sh-rp it is already bumped

@rudolfix rudolfix merged commit 662d4c9 into devel Jan 8, 2025
58 of 59 checks passed
@rudolfix rudolfix deleted the fix/handles-dates-from-to-arrow-scalar branch January 8, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants