Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontformat: show custom fonts only #368

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kagenihisomi
Copy link
Contributor

Allow font format box to show only custom fonts

Setting default is to show all fonts

Copy link
Owner

@dmMaze dmMaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, I forgot to submit.

ui/fontformatpanel.py Show resolved Hide resolved
@@ -348,6 +362,19 @@ def on_fontfamily_changed(self):
self.apply_fontfamily()


def showPopup(self):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will "show all fonts" be applied properly? After you check and uncheck "show only custom fonts" will all fonts be listed again? I haven't run it locally but it seems there are no means to restore all fonts here. Also, it's probably not a good idea to reset the font list every time it popup, it should be updated only once when let_show_only_custom_fonts.stateChanged triggered.

@hyrulelinks
Copy link
Contributor

The advantage of only displaying custom fonts is that you can only display the fonts that need to be used, but the actual situation is that you may occasionally need to use system fonts, if you need to restart and refresh the font library every time, this seems to be inconvenient, but it is true that the current display of all fonts is really a bit too much, switching fonts is very time-consuming and laborious, and the workload can be appropriately reduced with saved font templates, but there are still some inconvenient small defects in actual use, such as font size, the font of the small dialog box suddenly becomes very large, Fine-tuning is going to take extra effort again, and there doesn't seem to be a very suitable solution at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants