Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCID support #127

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add CCID support #127

wants to merge 7 commits into from

Conversation

kidbomb
Copy link

@kidbomb kidbomb commented May 11, 2023

No description provided.

@kidbomb kidbomb changed the title Add USB_DTYPE_FUNCTIONAL_DESC constant Add CCID support May 11, 2023
@kidbomb
Copy link
Author

kidbomb commented Jun 3, 2023

@dmitrystu Any chance of getting this merged?

@dmitrystu
Copy link
Owner

Sorry for the very late reply.
I need to check specs. https://www.usb.org/sites/default/files/DWG_Smart-Card_CCID_Rev110.pdf.

inc/usb_std.h Outdated Show resolved Hide resolved
inc/usb_ccid.h Outdated Show resolved Hide resolved
inc/usb_ccid.h Outdated Show resolved Hide resolved
@kidbomb
Copy link
Author

kidbomb commented Jun 27, 2023

Thanks for the review @dmitrystu - those are fixed.

inc/usb_ccid.h Outdated Show resolved Hide resolved
inc/usb_ccid.h Outdated Show resolved Hide resolved
@dmitrystu
Copy link
Owner

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

@kidbomb
Copy link
Author

kidbomb commented Jun 29, 2023

Just added all messages now

@kidbomb kidbomb requested a review from dmitrystu June 29, 2023 22:55
@kidbomb
Copy link
Author

kidbomb commented Jul 9, 2023

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

Any extra feedback on this?

@kidbomb
Copy link
Author

kidbomb commented Jul 23, 2023

Looks like this will add very basic CCID support, which is a good start. However, to achieve full support, Bulk-IN, Bulk-OUT, and Interrupt-IN messages must be added according to chapter 6 of CCID rev 1.1.

Any extra feedback on this?

@dmitrystu - Is there anything else you believe is missing? I would like to have this PR merged soon so I can start working on a feature for Flipper Zero

@kidbomb
Copy link
Author

kidbomb commented Sep 4, 2023

@dmitrystu - reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants