fix(video): Prevent hang in SkipFramesImpl by adding pop retry limit #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkipFramesImpl could hang when `decoder_->Pop` returned `false` after receiving an empty NDArray (EAGAIN signal), as the skip counter didn't decrement. If the decoder then stalled, `frame_count_` remained zero, causing subsequent `Pop` calls to fail rapidly at the entry check, leading to hangs or malloc deadlocks. This commit adds a retry limit to the `SkipFramesImpl` loop to break this rapid failure cycle after consecutive `Pop` failures. This improves robustness when skipping frames in problematic videos after seeking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkipFramesImpl could hang when
decoder_->Popreturnedfalseafter receiving an empty NDArray (EAGAIN signal), as the skip counter didn't decrement. If the decoder then stalled,frame_count_remained zero, causing subsequentPopcalls to fail rapidly at the entry check, leading to hangs or malloc deadlocks. This commit adds a retry limit to theSkipFramesImplloop to break this rapid failure cycle after consecutivePopfailures. This improves robustness when skipping frames in problematic videos after seeking.