Skip to content

Conversation

@ireneYang
Copy link

Description

This PR fixes compilation issues on macOS with newer versions of FFmpeg (5.x+). The changes address API incompatibilities and improve the build process for macOS users.

Changes

  1. Fixed av_find_best_stream function call parameter type for FFmpeg 5.x+
  2. Updated CMakeLists.txt to disable audio support by default to avoid FFmpeg compatibility issues
  3. Added macOS-specific compiler flags for better compatibility
  4. Fixed smart pointer definitions in ffmpeg_common.h for newer FFmpeg versions
  5. Updated build documentation for macOS users

Testing

  • Successfully compiled on macOS with FFmpeg 5.x+
  • Verified basic functionality of the library
  • Python bindings installed and working correctly

Related Issues

Fixes compilation errors related to:

  • av_find_best_stream function signature changes
  • AVBSFContextPtr definition issues
  • FFmpeg 5.x+ API deprecations

Notes for Reviewers

These changes primarily focus on compatibility with newer FFmpeg versions while maintaining backward compatibility. The audio support is disabled by default to avoid compilation issues, but can be enabled for environments where it works.

@jaminmc
Copy link

jaminmc commented Sep 11, 2025

Try my pull request. It fixes audio, and even adds GPU acceleration to decoding.
#355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants