-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Update thrust to the new monorepo CCCL #6166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
This is supposed to update to CCCL release with windows build error patch here: https://github.com/NVIDIA/cccl/tree/branch/2.2.x |
@Rhett-Ying Can we check if the windows CUDA build succeeds with this PR? |
thanks for your update. I will check it. |
1 task
@Rhett-Ying When is this PR planned to be merged? |
Rhett-Ying
approved these changes
Dec 5, 2023
DominikaJedynak
pushed a commit
to DominikaJedynak/dgl
that referenced
this pull request
Mar 12, 2024
Co-authored-by: Rhett Ying <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thrust, cub, and libcudacxx now are under the same repository called https://github.com/NVIDIA/cccl. The new release of CCCL
fixes the Windows compilation in #6135.