Skip to content

Conversation

@leofang
Copy link
Collaborator

@leofang leofang commented Apr 7, 2025

No description provided.

@leofang leofang requested a review from tqchen April 7, 2025 19:18
Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Leo. Changes are the addition of

DLPACK_FLAG_BITMASK_IS_SUBBYTE_TYPE_PADDED
float8<eXmY>
float6<eXmY>
float4<eXmY>

That all looks correct to me.

@rgommers
Copy link
Collaborator

rgommers commented Apr 8, 2025

CI is grumpy for some reason

@tqchen tqchen merged commit 688d2ba into dmlc:main Apr 10, 2025
1 of 5 checks passed
@tqchen
Copy link
Member

tqchen commented Apr 10, 2025

going to merge for now, seems was due to the lint download time out

@leofang leofang deleted the new_diag_1.1 branch April 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants