Skip to content

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented May 12, 2025

This PR updates the minimum required version of CMake. This change is necessary because the CMake 4.0 release removed policies that allowed supporting such old versions of CMake, so having such a low required minimum version of CMake prohibits using the latest versions. CMake 3.16 is already quite old (the release was back in 2019) and it is a reasonable choice based on Linux distro support (for example, it is the supported version for Ubuntu's 20.04 LTS release).

Resolves #162

@leofang
Copy link
Collaborator

leofang commented May 12, 2025

Thanks, Vyas! The CI failure is known for some time and irrelevant of this PR. I dunno why #162 was not closed by #163 (which bumped the minimum to 3.5), though. But I agree even 3.5 is very old and we can raise the bar a bit further.

@leofang leofang merged commit 5c210da into dmlc:main May 12, 2025
2 of 5 checks passed
@vyasr vyasr deleted the feat/update_cmake branch May 12, 2025 15:53
snnn pushed a commit to microsoft/onnxruntime that referenced this pull request May 14, 2025
adrianlizarraga pushed a commit to microsoft/onnxruntime that referenced this pull request Aug 5, 2025
adrianlizarraga pushed a commit to microsoft/onnxruntime that referenced this pull request Aug 5, 2025
quic-ankus pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake 4.0 support

2 participants