Optional normalization for the ranknet loss. #11272
Merged
+244
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
ltr-pairwise-norm
branch
from
7df44d2 to
b78a262
Compare
trivialfis
commented
Feb 21, 2025
trivialfis
commented
Feb 21, 2025
trivialfis
changed the title
hcho3
requested changes
Feb 25, 2025
|
Added a simple test. |
hcho3
approved these changes
Feb 25, 2025
|
Keeping the referenced issue open for now since there are unresolved issues with GPU build. I suspect it's the rng, but will wait for more updates before closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation has the seed
(iter + 1) *1111, while the current implementation usesiter. Otherwise, everything is the same when the set of hyper-parameters in the new document is used.