fix timing debug log

dmno-dev · Dec 11, 2024 · a530e2d · a530e2d
1 parent 275dfa7
commit a530e2d
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/packages/plugins/1password/src/cli-helper.ts b/packages/plugins/1password/src/cli-helper.ts
@@ -38,14 +38,21 @@ async function checkOpCliAuth() {
     // except for one further trick, which is to first check if we are already logged in, and resolve right away
     opAuthDeferred = createDeferredPromise();
     const startAt = new Date();
+    let isLoggedIn: boolean;
     try {
       await spawnAsync('op', ['whoami']);
-      opAuthDeferred.resolve(true);
+      isLoggedIn = true;
     } catch (err) {
+      isLoggedIn = false;
+    }
+
+    const whoamiTime = +new Date() - +startAt;
+    debug(`additional whoami check took ${whoamiTime}ms`);
+
+    if (isLoggedIn) {
+      opAuthDeferred.resolve(true);
+    } else {
       return opAuthDeferred.resolve;
-    } finally {
-      const whoamiTime = +new Date() - +startAt;
-      debug(`additional whoami check took ${whoamiTime}ms`);
     }
   }
 }