1pass plugin improvements #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 621fc82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
maintainer
✅ Deploy Preview for signup-api canceled.
|
✅ Deploy Preview for dmno ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
theoephraim
force-pushed
the
1pass-improvements
branch
2 times, most recently
from
9c18dd3 to
b2f47a8
Compare
|
commit: |
theoephraim
force-pushed
the
1pass-improvements
branch
from
b2f47a8 to
7cb863f
Compare
theoephraim
force-pushed
the
1pass-improvements
branch
from
7cb863f to
35bc4bc
Compare
philmillman
approved these changes
Aug 16, 2024
|
|
||
| </Steps> | ||
|
|
||
| This service account token will now serve as your "secret-zero" - which grants access to the rest of your sensitive config stored in 1password. It must be set locally and in deployed environments, and as it is sensitive, we must pass in the value as an _override_ rather than storing it within the config. Locally this usually means storing it in your `.env.local` and on a deployed environment you'll usually set it within some kind of UI, wherever you would normally pass in secrets. | ||
| This service account token will now serve as your "secret-zero" - which grants access to the rest of your sensitive config stored in 1Password. It must be set locally (unless relying on cli-based auth) and in deployed environments. It is sensitive and so we must pass in the value as an _override_ rather than storing it within the config. Locally this usually means storing it in your `.env.local` and on a deployed environment you'll usually set it within some kind of UI, wherever you would normally pass in secrets. |
There was a problem hiding this comment.
Suggested change
| This service account token will now serve as your "secret-zero" - which grants access to the rest of your sensitive config stored in 1Password. It must be set locally (unless relying on cli-based auth) and in deployed environments. It is sensitive and so we must pass in the value as an _override_ rather than storing it within the config. Locally this usually means storing it in your `.env.local` and on a deployed environment you'll usually set it within some kind of UI, wherever you would normally pass in secrets. | |
| This service account token will now serve as your _secret-zero_ - which grants access to the rest of your sensitive config stored in 1Password. It must be set locally (unless relying on CLI-based auth) and in deployed environments. It is sensitive and so we must pass in the value as an _override_ rather than storing it within the config. Locally this usually means storing it in your `.env.local` and on a deployed environment you'll usually set it within some kind of UI, wherever you would normally pass in secrets. |
There was a problem hiding this comment.
Maybe just explicitly say it will need to be set as an env var in the platform on which it's deployed.
| }); | ||
| ``` | ||
|
|
||
| Of course you could point to a `configPath` in your schema and toggle the opt-in based on some other logic if you'd like. |
There was a problem hiding this comment.
I'd skip this unless we're going to explain it.
Co-authored-by: Phil Miller <[email protected]>
philmillman
reviewed
Aug 16, 2024
philmillman
reviewed
Aug 16, 2024
theoephraim
force-pushed
the
1pass-improvements
branch
from
e86c3c9 to
cd1ed0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improving the 1password plugin, getting ready for real use and content publication.
opcli post install hook, rely on system installed version only