-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infisical plugin and docs cleanup #152
Conversation
🦋 Changeset detectedLatest commit: 8771082 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for dmno ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for signup-api canceled.
|
Implements #119 |
@@ -242,16 +226,9 @@ Field IDs are not easy to get from the 1Password UI. Luckily when the supplied f | |||
The secret reference for invidivual fields within an item can be found by clicking on the down arrow icon **on the field** and selecting `Copy Secret Reference`. | |||
::: | |||
|
|||
## Caching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still mention this stuff, but just not go into the details.
packages/docs-site/src/content/docs/docs/guides/secret-segmentation.mdx
Outdated
Show resolved
Hide resolved
::: | ||
|
||
## Setup Machine Account & Access Tokens | ||
|
||
Machine accounts can be granted access to projects, and each machine account can have multiple access tokens with optional expiration. How you want to manage this is up to you, but a sensible approach could be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is all specific to bitwarden's auth model, so might be good to leave in? It is also still part of the setup process, so at least still need to mention setting them up, and can then defer to the segmentation guide more about the strategy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sorry, if you want add the bitwarden specific stuff that makes sense back in, go for it, or just revert this whole file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave it out for now and I’ll go back in and try to slim it down and link back to the guide
Co-authored-by: Theo Ephraim <[email protected]>
commit: |
Adds support for reading secrets from Infisical. This first iteration supports universal auth and fetching individual secrets by name.
We may want to break out some of the new content that was added to Overview and give it its own nav items.