Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infisical plugin and docs cleanup #152

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Infisical plugin and docs cleanup #152

merged 6 commits into from
Nov 8, 2024

Conversation

philmillman
Copy link
Contributor

Adds support for reading secrets from Infisical. This first iteration supports universal auth and fetching individual secrets by name.

We may want to break out some of the new content that was added to Overview and give it its own nav items.

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 8771082

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@dmno/infisical-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the maintainer Created by an official project maintainer label Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for dmno ready!

Name Link
🔨 Latest commit 8771082
🔍 Latest deploy log https://app.netlify.com/sites/dmno/deploys/672d1f96802e0d00089dec60
😎 Deploy Preview https://deploy-preview-152--dmno.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for signup-api canceled.

Name Link
🔨 Latest commit 8771082
🔍 Latest deploy log https://app.netlify.com/sites/signup-api/deploys/672d1f96952f7a0008c65826

@philmillman
Copy link
Contributor Author

Implements #119

@philmillman philmillman added documentation Improvements or additions to documentation enhancement New feature or request plugins/infisical docs-site labels Nov 7, 2024
@philmillman philmillman self-assigned this Nov 7, 2024
example-repo/.dmno/config.mts Outdated Show resolved Hide resolved
example-repo/.dmno/config.mts Show resolved Hide resolved
@@ -242,16 +226,9 @@ Field IDs are not easy to get from the 1Password UI. Luckily when the supplied f
The secret reference for invidivual fields within an item can be found by clicking on the down arrow icon **on the field** and selecting `Copy Secret Reference`.
:::

## Caching
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still mention this stuff, but just not go into the details.

:::

## Setup Machine Account & Access Tokens

Machine accounts can be granted access to projects, and each machine account can have multiple access tokens with optional expiration. How you want to manage this is up to you, but a sensible approach could be:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all specific to bitwarden's auth model, so might be good to leave in? It is also still part of the setup process, so at least still need to mention setting them up, and can then defer to the segmentation guide more about the strategy?

Copy link
Contributor Author

@philmillman philmillman Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sorry, if you want add the bitwarden specific stuff that makes sense back in, go for it, or just revert this whole file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave it out for now and I’ll go back in and try to slim it down and link back to the guide

packages/plugins/infisical/README.md Show resolved Hide resolved
packages/plugins/infisical/package.json Outdated Show resolved Hide resolved
Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@dmno/infisical-plugin@152

commit: 8771082

@theoephraim theoephraim merged commit 0b25040 into main Nov 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-site documentation Improvements or additions to documentation enhancement New feature or request maintainer Created by an official project maintainer plugins/infisical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants