Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes nov 7 #153

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Bugfixes nov 7 #153

merged 3 commits into from
Nov 7, 2024

Conversation

theoephraim
Copy link
Member

  • required now inferred as true if static value set
  • small adjustments to tsconfig for dmno folder
  • bugfix for switchBy when no matching branch is found (was crashing on ResolutionError instead of just attaching it to the node

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: a10f250

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@dmno/configraph Patch
dmno Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for signup-api canceled.

Name Link
🔨 Latest commit a10f250
🔍 Latest deploy log https://app.netlify.com/sites/signup-api/deploys/672d03af2fa67c00086fbe89

@github-actions github-actions bot added the maintainer Created by an official project maintainer label Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for dmno ready!

Name Link
🔨 Latest commit a10f250
🔍 Latest deploy log https://app.netlify.com/sites/dmno/deploys/672d03af0d670c0008fdf50b
😎 Deploy Preview https://deploy-preview-153--dmno.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@dmno/configraph@153
pnpm add https://pkg.pr.new/dmno@153

commit: a10f250

Copy link
Contributor

@philmillman philmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@theoephraim theoephraim merged commit bd44871 into main Nov 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer Created by an official project maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants