Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1pass-tweaks #178

Merged
merged 4 commits into from
Dec 11, 2024
Merged

1pass-tweaks #178

merged 4 commits into from
Dec 11, 2024

Conversation

theoephraim
Copy link
Member

  • fix quote issue with some cases passing args to op cli
  • ensure 1pass auth popup only shows once, even when making multiple parallel requests
  • make more requests batchable
  • deprecate pulling overrides from an item without specifying vault id
  • renamed name to item in object format of override location

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: a530e2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@dmno/1password-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the maintainer Created by an official project maintainer label Dec 10, 2024
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for dmno ready!

Name Link
🔨 Latest commit a530e2d
🔍 Latest deploy log https://app.netlify.com/sites/dmno/deploys/6759d0088b5a88000884fcfa
😎 Deploy Preview https://deploy-preview-178--dmno.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for signup-api canceled.

Name Link
🔨 Latest commit a530e2d
🔍 Latest deploy log https://app.netlify.com/sites/signup-api/deploys/6759d00861ec8a0008795b76

Copy link

pkg-pr-new bot commented Dec 10, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@dmno/1password-plugin@178

commit: a530e2d

@theoephraim theoephraim merged commit 1a52755 into main Dec 11, 2024
12 checks passed
@Inlustra
Copy link

Inlustra commented Dec 15, 2024

It looks like pkg.pr.new removes the packages once they've been merged. This is resulting in broken builds and given that they aren't released in the main branch straight away, I have to go and figure out which pkg.pr.new packages from other pull requests I should replace them with! 😅

Just raising as it's getting difficult to know which packages I should be using!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer Created by an official project maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants