introduce includeInDmnoConfig option
#182
Merged
+110
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
maintainer
✅ Deploy Preview for dmno ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for signup-api canceled.
|
theoephraim
force-pushed
the
include-dmno-env
branch
from
fc294c7 to
31f19eb
Compare
🦋 Changeset detectedLatest commit: 31f19eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@dmno/configraph
dmno
@dmno/remix-integration
@dmno/vite-integration
@dmno/bitwarden-plugin
@dmno/1password-plugin
@dmno/encrypted-vault-plugin
@dmno/infisical-plugin
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this lets items opt out of being included in the injected dmno config globals. This is useful for things like a 1password service account token which is needed to resolve your config, but never needed within your application. Especially when we are injecting resolved config into built code, we want to keep those values out of it.
The primary driver for this is keeping the cloudflare api token out of the built cloudflare worker code.