Skip to content

A few minor improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

A few minor improvements #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
77610ca
Update README.md
wootosmash Jun 1, 2019
691666e
Update package.json
wootosmash Jun 1, 2019
ecfeb13
Update CMakeLists.txt
wootosmash Jun 1, 2019
79a2816
Update CMakeLists.txt
wootosmash Jun 1, 2019
5cbb1b2
Update CMakeLists.txt and package.json
nanokina Feb 22, 2020
89e448e
Fix node-libsamplerate.cc
nanokina Feb 22, 2020
db268ad
Fix package.json
nanokina Feb 23, 2020
1dc73f8
Fix memory leak
nanokina Feb 28, 2020
8c33698
Fix another memory leak
nanokina Feb 28, 2020
c1de8c6
Update package-lock.json
nanokina Feb 28, 2020
40292a6
Fix failing test
nanokina Feb 28, 2020
cc9f9d7
merge
wootosmash Oct 10, 2020
cade85e
Merge branch 'nanokina-master' into master
wootosmash Oct 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,16 @@ set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "" SUFFIX ".node")

# Essential include files to build a node addon,
# You should add this line in every CMake.js based project
#target_include_directories(${PROJECT_NAME} )
target_include_directories(${PROJECT_NAME} PRIVATE ${CMAKE_JS_INC})

# Include N-API wrappers
target_include_directories(${PROJECT_NAME} PRIVATE ${CMAKE_JS_INC} PRIVATE "${CMAKE_SOURCE_DIR}/node_modules/node-addon-api")
execute_process(COMMAND node -p "require('node-addon-api').include"
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
OUTPUT_VARIABLE NODE_ADDON_API_DIR
)
string(REPLACE "\n" "" NODE_ADDON_API_DIR ${NODE_ADDON_API_DIR})
string(REPLACE "\"" "" NODE_ADDON_API_DIR ${NODE_ADDON_API_DIR})
target_include_directories(${PROJECT_NAME} PRIVATE ${NODE_ADDON_API_DIR})

# Essential library files to link to a node addon
# You should add this line in every CMake.js based project
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ where options is an object of the form:
```javascript
let options = {
// Value can be from 0 to 4 or using enum. 0 is the best quality and the slowest.
type: SampleRate.SRC_SINC_MEDIUM_QALITY,
type: SampleRate.SRC_SINC_MEDIUM_QUALITY,
// Stereo
channels: 2,
// Sample rate of source
Expand Down Expand Up @@ -59,4 +59,4 @@ If recording from `arecord`, `sox` or similar, use format `raw`.

### Altering playback speed

This is possible by modifying the converter ratio, which can be done on the fly using the `setRatio` method. e.g. `resample.setRatio(0.5)`. Depending upon timing, this will most likely take effect at the next buffer load. If fine grained modifications to playback speed are required, then a small value for `highWaterMark` on the input stream will be needed.
This is possible by modifying the converter ratio, which can be done on the fly using the `setRatio` method. e.g. `resample.setRatio(0.5)`. Depending upon timing, this will most likely take effect at the next buffer load. If fine grained modifications to playback speed are required, then a small value for `highWaterMark` on the input stream will be needed.
Loading