Update assignment_1.ipynb #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatelVishakh
suggested changes
Dec 19, 2025
PatelVishakh
left a comment
PatelVishakh
left a comment
There was a problem hiding this comment.
Assignment 1: Incomplete. Needs a few changes.
Required Changes:
Q1)III) The type of variable is categorical. In a data science setting, this question is asking whether the variable is continuous or categorial(integer, ordinal are other options).
Q3)II)range(1:51) as python doesn’t include last index, also no need to do skip since our grid is not very big.
Q3)IV) need to identify the best parameter value
Q3) IV) "estimator=KNeighborsClassifier(n_neighbors=6)" why 6?
Made suggested changes
Updated and made suggested changes to assignment 1. Thanks Vishakh
PatelVishakh
approved these changes
Dec 21, 2025
PatelVishakh
left a comment
PatelVishakh
left a comment
There was a problem hiding this comment.
Assignment 1:Complete! Great edits!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist