FN-7 나도 써주기 기능 추가 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 자세히 보기 해당 버튼 내부 기능으로 이동 - 나도 써주기 기능 추가
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue No.
#85
작업 내역
세부사항
5번 비회원인 경우 senderWikiId를 null로 넘겨주기로 했는데, 해당 경우 404 페이지로 이동중입니다. 그전에 비회원이라고 알릴지, 아니면 애초에 바텀시트에서 나도써주기 자체가 없도록 구현할건지 논의중인거 같네요. 작업 다 끝내니 변경사항이 생기는 거 같아서 일단은 배포하지 않는데 좋을거 같아요-> 논의 완료 되었고, 나도 써주기 클릭 시 비회원인 경우 모달 띄우는 걸로 수정 되어 해당 사항 반영했습니다.
웹뷰에서 바텀시트가 메인섹션에만 올라오도록 하려면, 어디 수정해야하는지 알려주시면 감사하겠습니다.
화면 결과 (캡쳐 첨부)
2024-03-21.7.29.34.mov