fix: 목표 달성 실패 시 title "달성 실패"로 리턴

- 내부 테스트 관련 이슈 리스트(#7) 이슈 해결
dnd-side-project · Sep 30, 2024 · 54bf633 · 54bf633
1 parent fb22830
commit 54bf633
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/main/java/com/dnd/runus/domain/goalAchievement/GoalAchievement.java b/src/main/java/com/dnd/runus/domain/goalAchievement/GoalAchievement.java
@@ -27,12 +27,13 @@ public GoalAchievement(RunningRecord runningRecord, GoalMetricType goalMetricTyp
                 goalMetricType.getActualValue(runningRecord) >= achievementValue);
     }
 
-    public String getTitle() {
+    public String getTitle(boolean isAchieved) {
+        String returnTitle = (isAchieved ? " 달성" : " 달성 실패");
         if (goalMetricType == DISTANCE) {
-            return KILO_METER_FORMATTER.format(achievementValue / METERS_IN_A_KILOMETER) + " 달성";
+            return KILO_METER_FORMATTER.format(achievementValue / METERS_IN_A_KILOMETER) + returnTitle;
         }
 
-        return formatSecondToKoreanHHMM(achievementValue) + " 달성";
+        return formatSecondToKoreanHHMM(achievementValue) + returnTitle;
     }
 
     public String getDescription() {

diff --git a/...va/com/dnd/runus/presentation/v1/running/dto/response/RunningRecordAddResultResponse.java b/...va/com/dnd/runus/presentation/v1/running/dto/response/RunningRecordAddResultResponse.java
@@ -54,7 +54,7 @@ public static RunningRecordAddResultResponse of(RunningRecord runningRecord, Goa
         return buildResponse(runningRecord,
                 null,
                 new GoalResultDto(
-                        achievement.getTitle(),
+                        achievement.getTitle(achievement.isAchieved()),
                         achievement.getDescription(),
                         achievement.getIconUrl(),
                         achievement.isAchieved()

diff --git a/...n/java/com/dnd/runus/presentation/v1/running/dto/response/RunningRecordQueryResponse.java b/...n/java/com/dnd/runus/presentation/v1/running/dto/response/RunningRecordQueryResponse.java
@@ -54,7 +54,7 @@ public static RunningRecordQueryResponse of(RunningRecord runningRecord, GoalAch
         return buildResponse(runningRecord,
                 null,
                 new GoalResultDto(
-                        achievement.getTitle(),
+                        achievement.getTitle(achievement.isAchieved()),
                         achievement.getDescription(),
                         achievement.getIconUrl(),
                         achievement.isAchieved()