Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OpenweathermapWeatherClient 예보 정보를 받아와 일일 최고 최저 기온를 반환하도록 수정 #254

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

WonSteps
Copy link
Member

@WonSteps WonSteps commented Oct 3, 2024

🔗 이슈 연결

🚀 구현한 API

  • x

💡 반영할 내용 및 변경 사항 요약

  • OpenweathermapWeatherInfo dto를 OpenweathermapCurrent로 이름을 변경합니다. (32b1cc1)
  • 기존의 OpenweathermapWeatherClient에서는 현재 온도만 요청하는 데, 예보 정보를 요청하도록 수정합니다.(471186e)
    • 받아온 3시간 단위의 8개 예보 정보에서 최고/최저 기온을 찾습니다.
    • 기존의 해당 도시의 최고/최저 기온 대신, 예보 정보를 사용하도록 수정합니다.

🔍 리뷰 요청/참고 사항

@WonSteps WonSteps added the bug Something isn't working label Oct 3, 2024
@WonSteps WonSteps self-assigned this Oct 3, 2024
@WonSteps WonSteps changed the title Fix: OpenweathermapWeatherClient 일일 최고 최저 기온도 요청하도록 수정 Fix: OpenweathermapWeatherClient 예보 정보를 받아와 일일 최고 최저 기온를 반환하도록 수정 Oct 3, 2024
@WonSteps WonSteps requested a review from hee9841 October 3, 2024 02:55
Copy link
Collaborator

@hee9841 hee9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@WonSteps WonSteps merged commit 004cf02 into main Oct 4, 2024
1 check passed
@WonSteps WonSteps deleted the feature/#253/weather-min-max branch October 4, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openweathermap 일일 최고 / 최저 기온이 올바르지 못한 문제
2 participants