Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: 러닝 결과 추가 관련 함수 및 클래스 이름 변경(기존 V1) #321

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Refactor: 러닝 결과 추가 관련 함수 및 클래스 이름 변경(기존 V1) #321

merged 3 commits into from
Dec 23, 2024

Conversation

hee9841
Copy link
Collaborator

@hee9841 hee9841 commented Dec 19, 2024

🔗 이슈 연결

🚀 구현한 API

  • X

💡 반영할 내용 및 변경 사항 요약

  • 네이밍을 명확하게 하기 위해 RunningRecordAddResultResponse -> RunningRecordAddResultResponseV1 으로, RunningRecordRequest -> RunningRecordRequestV1으로 클래스명 변경
  • V2 서비스 단 함수를 추가하기 위해 기존 addRunningRecord함수를 addRunningRecordV1으로 변경
  • 서비스단 함수 순서 변경(get -> add -> private 순)

🔍 리뷰 요청/참고 사항

@hee9841 hee9841 added the refactor 코드 리팩토링 label Dec 19, 2024
@hee9841 hee9841 self-assigned this Dec 19, 2024
@hee9841 hee9841 requested a review from WonSteps December 19, 2024 11:32
WonSteps
WonSteps approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@WonSteps WonSteps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@hee9841 hee9841 merged commit 65bdadf into main Dec 23, 2024
1 check passed
@hee9841 hee9841 deleted the refactor/#319/running-course branch December 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WonSteps WonSteps WonSteps approved these changes

Assignees

@hee9841 hee9841

Labels
refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hee9841 @WonSteps